/
Code reviews

Code reviews

Owned by Farai Mutambara

When you have tested and pushed your code, you will need to get code reviews from relevant people.

The process to getting code reviews:

  1. Create a pull request in the relevant repo

  2. Fill in the required details

  3. Add the review: please label

  4. If you're unsure about your solution to a merge conflict, request a re-review.

Who needs to review my code?

To work out who needs to review your code, consider who the changes may impact. If they impact just your area (STFC or ESS), you need to get one review from your colleagues. If it impacts both areas, get one review from both sides.